[ 
https://issues.apache.org/jira/browse/HIVE-4806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715892#comment-13715892
 ] 

Alan Gates commented on HIVE-4806:
----------------------------------

This looks really good, especially adding all of the JDK 1.7 calls.  A few 
comments:
* HiveConnection.setReadOnly - you note that HS2 should only support true here. 
 But that isn't right.  You can do things like "create table foo as select 
...".  
* HiveDatabaseMetaData.supportsResultSetConcurrency - have you tested that it 
supports concurrent read under the conditions given in the method?
* HiveResultsSetMetaData.getColumnTypeName - afaik Hive doesn't support bool, 
byte, i32 or i64 as type names anywhere else.  Why add them here?
                
> Add more implementations of JDBC API methods to Hive and Hive2 drivers
> ----------------------------------------------------------------------
>
>                 Key: HIVE-4806
>                 URL: https://issues.apache.org/jira/browse/HIVE-4806
>             Project: Hive
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 0.11.0
>            Reporter: Matt Burgess
>             Fix For: 0.12.0
>
>         Attachments: HIVE-4806.patch
>
>
> Third-party client software such as Pentaho Data Integration (PDI) uses many 
> different JDBC API calls when interacting with JDBC data sources. Several of 
> these calls have not yet been implemented in the Hive and Hive 2 drivers and 
> by default will throw "Method not supported" SQLExceptions when there could 
> be default implementations instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to