[ 
https://issues.apache.org/jira/browse/HIVE-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717747#comment-13717747
 ] 

Phabricator commented on HIVE-3926:
-----------------------------------

hagleitn has commented on the revision "HIVE-3926 [jira] PPD on virtual column 
of partitioned table is not working".

  Some minor comments + request for more info.

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java:600 tableScanOperator was 
actually a clearer name, wasn't it?
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java:108 I think this 
is redundant. o instanceof MapInputPath is false if o == null
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java:134 
can you please add a javadoc comment here?
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java:18 There are a 
lot of changes in MapOperator. I've scan through them and it seems most (all?) 
are just cleaning up the operator (which is great).

  Is that correct? If not can you please point out what the important changes 
are?

REVISION DETAIL
  https://reviews.facebook.net/D8121

To: JIRA, navis
Cc: hagleitn

                
> PPD on virtual column of partitioned table is not working
> ---------------------------------------------------------
>
>                 Key: HIVE-3926
>                 URL: https://issues.apache.org/jira/browse/HIVE-3926
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-3926.D8121.1.patch, HIVE-3926.D8121.2.patch, 
> HIVE-3926.D8121.3.patch, HIVE-3926.D8121.4.patch
>
>
> {code}
> select * from src where BLOCK__OFFSET__INSIDE__FILE<100;
> {code}
> is working, but
> {code}
> select * from srcpart where BLOCK__OFFSET__INSIDE__FILE<100;
> {code}
> throws SemanticException. Disabling PPD makes it work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to