[
https://issues.apache.org/jira/browse/HIVE-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717851#comment-13717851
]
Phabricator commented on HIVE-4880:
-----------------------------------
hagleitn has requested changes to the revision "HIVE-4880 [jira] Rearrange
explain order of stages simpler".
Some minor comments. Have you run this? It might not actually give you too
many changes in the golden files.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java:352
rearrange sounds like you'll change the order of execution or juggle operators
arround. i think assignStageIds or assignFinalStageIds would be clearer.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/StageIDRearranger.java:47
can you rename to getChildTasks? or getChildren?
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/StageIDRearranger.java:13
Are you sure? I thought execution order is different. For instance: We will
run all the root stages first, and then all their children, etc. Don't we?
You're algo goes deep first.
REVISION DETAIL
https://reviews.facebook.net/D11733
BRANCH
HIVE-4880
ARCANIST PROJECT
hive
To: JIRA, hagleitn, navis
> Rearrange explain order of stages simpler
> -----------------------------------------
>
> Key: HIVE-4880
> URL: https://issues.apache.org/jira/browse/HIVE-4880
> Project: Hive
> Issue Type: Improvement
> Components: Diagnosability
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: HIVE-4880.D11733.1.patch
>
>
> Current explain order of stages is not best form to read (and to debug)
> {noformat}
> Before:
> STAGE DEPENDENCIES:
> Stage-1 is a root stage
> Stage-7 depends on stages: Stage-1 , consists of Stage-4, Stage-3, Stage-5
> Stage-4
> Stage-0 depends on stages: Stage-4, Stage-3, Stage-6
> Stage-9 depends on stages: Stage-0
> Stage-2 depends on stages: Stage-9
> Stage-3
> Stage-5
> Stage-6 depends on stages: Stage-5
> After:
> STAGE DEPENDENCIES:
> Stage-1 is a root stage
> Stage-2 depends on stages: Stage-1 , consists of Stage-3, Stage-4, Stage-5
> Stage-3
> Stage-4
> Stage-5
> Stage-6 depends on stages: Stage-5
> Stage-7 depends on stages: Stage-3, Stage-4, Stage-6
> Stage-8 depends on stages: Stage-7
> Stage-9 depends on stages: Stage-8
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
