[
https://issues.apache.org/jira/browse/HIVE-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728193#comment-13728193
]
Yin Huai commented on HIVE-4979:
--------------------------------
{code}
<target name="test" depends="clean-test,jar-test" description="Run tests">
<echo message="Project: ${ant.project.name}"/>
<if>
<isset property="module"/>
<else>
<antcall target="test-shims">
<param name="hadoop.version.ant-internal"
value="${hadoop.security.version}" />
</antcall>
</else>
</if>
<condition property="target.module" value="${module}"
else="${iterate.hive.test}">
<isset property="module"/>
</condition>
<for keepgoing="${test.continue.on.failure}" list="${target.module}"
param="module">
<sequential>
<ant antfile="@{module}/build.xml" target="test" inheritAll="false"
inheritRefs="true">
<property name="build.dir.hive" location="${build.dir.hive}"/>
<property name="is-offline" value="${is-offline}"/>
</ant>
</sequential>
</for>
</target>
<target name="test-shims">
<echo message="Project: ${ant.project.name}"/>
<subant target="test" failonerror="${test.halt.on.failure}">
<property name="hadoop.version" value="${hadoop.security.version}"/>
<property name="hadoop.security.version"
value="${hadoop.security.version}"/>
<fileset dir="${hive.root}/shims" includes="build.xml"/>
</subant>
</target>
{\code}
This part of code is from build.xml. I am not familiar with ant. Here is my
understanding...
When I use 'ant test -Dmodule=shims', test-shims will not be called. Then, the
build will stop when there is a compile error.
But when we do not specific the module to shims, test-shims will be triggered.
At here, failonerror will be 'no'.
What I am not sure is why we have a separate target for test-shims? Why it is
not a part of 'iterate.hive.full.tests' (it has
ql,contrib,hbase-handler,hwi,jdbc,beeline,metastore,odbc,serde,service,hcatalog).
> If any compiling error exists, test-shims should stop
> -----------------------------------------------------
>
> Key: HIVE-4979
> URL: https://issues.apache.org/jira/browse/HIVE-4979
> Project: Hive
> Issue Type: Sub-task
> Reporter: Yin Huai
> Assignee: Yin Huai
> Attachments: HIVE-4979.4980.failedTest.txt, HIVE-4979.D11931.1.patch,
> HIVE-4979.D11931.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
