[
https://issues.apache.org/jira/browse/HIVE-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13729665#comment-13729665
]
Edward Capriolo commented on HIVE-4964:
---------------------------------------
With a quick look.
1) Your not using the correct formatting rules for the project. We can not
accept code that does not match the coding conventions
{code}
+ while (pItr.hasNext())
+ {
+ Object oRow = pItr.next();
+ forward(oRow, outputObjInspector);
+ }
{code}
2) The implementing class should not be on the left side of the equals. Use
List not ArrayList when possible.
{code}
ArrayList<ObjectInspector> fieldOIs = new ArrayList<ObjectInspector>();
{code}
> Cleanup PTF code: remove code dealing with non standard sql behavior we had
> original introduced
> -----------------------------------------------------------------------------------------------
>
> Key: HIVE-4964
> URL: https://issues.apache.org/jira/browse/HIVE-4964
> Project: Hive
> Issue Type: Bug
> Reporter: Harish Butani
> Priority: Minor
> Attachments: HIVE-4964.D11985.1.patch
>
>
> There are still pieces of code that deal with:
> - supporting select expressions with Windowing
> - supporting a filter with windowing
> Need to do this before introducing Perf. improvements.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
