----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13315/#review24748 -----------------------------------------------------------
jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java <https://reviews.apache.org/r/13315/#comment48859> moving the lines for "// read the config value and verify its set correctly" into a private function will make it easier to read the test. jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java <https://reviews.apache.org/r/13315/#comment48857> Are the two ps.executeQuery() calls intentional ? (line 416,418). jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java <https://reviews.apache.org/r/13315/#comment48858> looks like a redundant check here. - Thejas Nair On Aug. 6, 2013, 8:08 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13315/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 8:08 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5006 > https://issues.apache.org/jira/browse/HIVE-5006 > > > Repository: hive-git > > > Description > ------- > > The JDBC PreparedStatement interface extends Statement interface. The Hive > JDBC driver implementations of HivePreparedStatement interface is disjoint > from the HiveStatement implementation. As a result there's some duplicate > code in these two classes for executing query. Also patches like implicit > close on re-execute etc. are not there for PreparedStatement. > Hive doesn't support parameters binding. The prepared statement > implementation is basically to replace '?' in the statements with the bound > parameters values. This implementation useful for migrating existing > applications/tools to Hive that use prepared statement. > > The patch refactors HivePreparedStatement to extend the HiveStatement. The > PreparedStatement specific methods like execute(), executeQuery() etc. are > simply replacing the parameters and then call corresponding methods in the > underlying HiveStatement. > > > Diffs > ----- > > jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java dfcd536 > jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java 1042125 > > Diff: https://reviews.apache.org/r/13315/diff/ > > > Testing > ------- > > Added PreparedStatement test scenarios to TestJdbcDriver2. The existing tests > for PreparedStatement also pass with the patch. > > > Thanks, > > Prasad Mujumdar > >
