[
https://issues.apache.org/jira/browse/HIVE-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731564#comment-13731564
]
Phabricator commented on HIVE-4246:
-----------------------------------
hagleitn has commented on the revision "HIVE-4246 [jira] Implement predicate
pushdown for ORC".
LGTM
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java:1455 typo
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java:1483 aka
enum?
ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java:142 this
record reader helper seems a little out of place in truthvalue, no?
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInStream.java:128 break the
string?
ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java:243 i know
it's not yours, but sed /java.util.ArrayList/List/g would probably be good in
this file.
ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java:244 why do
you need the names?
REVISION DETAIL
https://reviews.facebook.net/D11415
To: JIRA, omalley
Cc: hagleitn
> Implement predicate pushdown for ORC
> ------------------------------------
>
> Key: HIVE-4246
> URL: https://issues.apache.org/jira/browse/HIVE-4246
> Project: Hive
> Issue Type: New Feature
> Components: File Formats
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-4246.D11415.1.patch
>
>
> By using the push down predicates from the table scan operator, ORC can skip
> over 10,000 rows at a time that won't satisfy the predicate. This will help a
> lot, especially if the file is sorted by the column that is used in the
> predicate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
