[ https://issues.apache.org/jira/browse/HIVE-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-4324: ------------------------------ Attachment: HIVE-4324.D12045.1.patch omalley requested code review of "HIVE-4324 [jira] ORC Turn off dictionary encoding when number of distinct keys is greater than threshold". Reviewers: JIRA forward port of kevin's patch Add a configurable threshold so that if the number of distinct values in a string column is greater than that fraction of non-null values, dictionary encoding is turned off. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D12045 AFFECTED FILES common/src/java/org/apache/hadoop/hive/conf/HiveConf.java conf/hive-default.xml.template ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFile.java ql/src/java/org/apache/hadoop/hive/ql/io/orc/OutStream.java ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java ql/src/java/org/apache/hadoop/hive/ql/io/orc/StringRedBlackTree.java ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFileDump.java ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java ql/src/test/queries/clientpositive/orc_dictionary_threshold.q ql/src/test/resources/orc-file-dump-dictionary-threshold.out ql/src/test/results/clientpositive/orc_dictionary_threshold.q.out MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/28797/ To: JIRA, omalley > ORC Turn off dictionary encoding when number of distinct keys is greater than > threshold > --------------------------------------------------------------------------------------- > > Key: HIVE-4324 > URL: https://issues.apache.org/jira/browse/HIVE-4324 > Project: Hive > Issue Type: Sub-task > Components: File Formats > Affects Versions: 0.11.0 > Reporter: Kevin Wilfong > Assignee: Kevin Wilfong > Attachments: HIVE-4324.1.patch.txt, HIVE-4324.D12045.1.patch > > > Add a configurable threshold so that if the number of distinct values in a > string column is greater than that fraction of non-null values, dictionary > encoding is turned off. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira