[
https://issues.apache.org/jira/browse/HIVE-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13732595#comment-13732595
]
Phabricator commented on HIVE-4324:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-4324 [jira] ORC Turn off
dictionary encoding when number of distinct keys is greater than threshold".
Mostly looks good, except for some minor nits.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OutStream.java:249 Is it better
to modify clear to accept compress and suppress arguments ?
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java:768 Good
to add a javadoc saying this Reader reads strings which doesn't have
accompanying dictionary.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java:838
Similarly here, javadoc of effect : This reader reads dictionary encoded
strings.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/StringRedBlackTree.java:166 This
method could be package private?
REVISION DETAIL
https://reviews.facebook.net/D12045
BRANCH
h-4324
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, omalley
> ORC Turn off dictionary encoding when number of distinct keys is greater than
> threshold
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-4324
> URL: https://issues.apache.org/jira/browse/HIVE-4324
> Project: Hive
> Issue Type: Sub-task
> Components: File Formats
> Affects Versions: 0.11.0
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-4324.1.patch.txt, HIVE-4324.D12045.1.patch
>
>
> Add a configurable threshold so that if the number of distinct values in a
> string column is greater than that fraction of non-null values, dictionary
> encoding is turned off.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
