[ https://issues.apache.org/jira/browse/HIVE-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736316#comment-13736316 ]
Hudson commented on HIVE-5046: ------------------------------ SUCCESS: Integrated in Hive-trunk-h0.21 #2260 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2260/]) HIVE-5046: Hcatalog's bin/hcat script doesn't respect HIVE_HOME (Mark Grover via Brock Noland) (brock: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1512832) * /hive/trunk/hcatalog/bin/hcat > Hcatalog's bin/hcat script doesn't respect HIVE_HOME > ---------------------------------------------------- > > Key: HIVE-5046 > URL: https://issues.apache.org/jira/browse/HIVE-5046 > Project: Hive > Issue Type: Bug > Components: HCatalog > Affects Versions: 0.11.0 > Reporter: Mark Grover > Assignee: Mark Grover > Fix For: 0.12.0 > > Attachments: HIVE-5046.1.patch > > > https://github.com/apache/hive/blob/trunk/hcatalog/bin/hcat#L81 > The quoted snippet (see below) intends to set HIVE_HOME if it's not set (i.e. > HIVE_HOME is currently null). > {code} > if [ -n ${HIVE_HOME} ]; then > {code} > However, {{-n}} checks if the variable is _not_ null. So, the above code ends > up setting HIVE_HOME to the default value if it is actually set already, > overriding the set value. This condition needs to be negated. > Moreover, {{-n}} checks requires the string being tested to be enclosed in > quotes. > Reference: > http://tldp.org/LDP/abs/html/comparison-ops.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira