[
https://issues.apache.org/jira/browse/HIVE-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749276#comment-13749276
]
Phabricator commented on HIVE-5137:
-----------------------------------
thejas has commented on the revision "HIVE-5137 [jira] A Hive SQL query should
not return a ResultSet when the underlying plan does not include a
FetchTaskSQL".
Looks good. Just 2 minor nits.
INLINE COMMENTS
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:113
Can you make it something like ""Error running query: Schema and FieldSchema
should be set when query plan has a FetchTask"
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:109
I think its a little easier to read to write it this way-
if(driver.getPlan().getFetchTask() != null) {
//Schema has to be set
if(not schema set){
throw error;
}
..
setHasResultSet(true);
}
REVISION DETAIL
https://reviews.facebook.net/D12453
To: JIRA, vaibhavgumashta
Cc: thejas
> A Hive SQL query should not return a ResultSet when the underlying plan does
> not include a FetchTask
> ----------------------------------------------------------------------------------------------------
>
> Key: HIVE-5137
> URL: https://issues.apache.org/jira/browse/HIVE-5137
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Affects Versions: 0.11.0
> Reporter: Vaibhav Gumashta
> Assignee: Vaibhav Gumashta
> Attachments: HIVE-5137.D12453.1.patch, HIVE-5137.D12453.2.patch,
> HIVE-5137.D12453.3.patch, HIVE-5137.D12453.4.patch, HIVE-5137.D12453.5.patch,
> HIVE-5137.D12453.6.patch
>
>
> Currently, a query like "create table if not exists t2 as select * from t1"
> sets the hasResultSet to true in SQLOperation and in turn, the query returns
> a result set. However, as a DDL command, this should ideally not return a
> result set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
