[
https://issues.apache.org/jira/browse/HIVE-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751697#comment-13751697
]
Sushanth Sowmyan commented on HIVE-4331:
----------------------------------------
I've gone through the HCat section of the patch as well, and I'm okay with it.
I give that my +1 as well, pending the commit of the hive side of the patch,
and making sure that checkstyle passes the changes (My guess, right now, is
that with word-wrapping the Apache license headers, it won't)
--
The only changes needed, on my end, are on the hive side, and are minor
code-style and implementation issues, such as using raw strings, and using a
map where there wasn't a need for one. If those are addressed, this patch is
good to go. (Also, the whole patch will need a rebase to be applicable to trunk
right now)
> Integrated StorageHandler for Hive and HCat using the HiveStorageHandler
> ------------------------------------------------------------------------
>
> Key: HIVE-4331
> URL: https://issues.apache.org/jira/browse/HIVE-4331
> Project: Hive
> Issue Type: Task
> Components: HCatalog
> Affects Versions: 0.11.0, 0.12.0
> Reporter: Ashutosh Chauhan
> Assignee: Viraj Bhat
> Attachments: HIVE4331_07-17.patch, StorageHandlerDesign_HIVE4331.pdf
>
>
> 1) Deprecate the HCatHBaseStorageHandler and "RevisionManager" from HCatalog.
> These will now continue to function but internally they will use the
> "DefaultStorageHandler" from Hive. They will be removed in future release of
> Hive.
> 2) Design a HivePassThroughFormat so that any new StorageHandler in Hive will
> bypass the HiveOutputFormat. We will use this class in Hive's
> "HBaseStorageHandler" instead of the "HiveHBaseTableOutputFormat".
> 3) Write new unit tests in the HCat's "storagehandler" so that systems such
> as Pig and Map Reduce can use the Hive's "HBaseStorageHandler" instead of the
> "HCatHBaseStorageHandler".
> 4) Make sure all the old and new unit tests pass without backward
> compatibility (except known issues as described in the Design Document).
> 5) Replace all instances of the HCat source code, which point to
> "HCatStorageHandler" to use the"HiveStorageHandler" including the
> "FosterStorageHandler".
> I have attached the design document for the same and will attach a patch to
> this Jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
