[ 
https://issues.apache.org/jira/browse/HIVE-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758157#comment-13758157
 ] 

Edward Capriolo commented on HIVE-5203:
---------------------------------------

I was thinking you could use mock up a class with a few methods with signatures 
you are looking to hit.

{code}
  MyTestClass {
    eval(String)
    eval(Text)
    eval(int)
  }
{code}

Then use that code in a test case and maybe use mockito to show that the logic 
is finding the method you want. 

Really as long as it continues to work the same way (current tests) we know it 
is correct, but it would be nice to have a more direct way to show how this 
logic works (with a unit test). Just a thought.
                
> FunctionRegistry.getMethodInternal() should prefer method arguments with 
> closer affinity to the original argument types
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5203
>                 URL: https://issues.apache.org/jira/browse/HIVE-5203
>             Project: Hive
>          Issue Type: Bug
>          Components: Types, UDF
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: HIVE-5203.1.patch
>
>
> When the function registry is trying to determine the best version of UDF 
> evaluate() to use based on a set of arguments passed in, it should prefer 
> methods where the argument types are more related to the original types. For 
> example if varchar is used with UDFFromUnixTime(), varchar is convertible to 
> both the double and string versions of evaluate() for that UDF.  In this case 
> we would prefer that the function registry select the string version over the 
> double version, since varchar and string are both string types.
> This doesn't really affect any of the existing types, but comes into play 
> with the addition of the varchar type (HIVE-4844).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to