[
https://issues.apache.org/jira/browse/HIVE-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761140#comment-13761140
]
Sushanth Sowmyan commented on HIVE-4331:
----------------------------------------
Ooh, ouch, yes. I see the problem.
Your patch has two parts - the hive part and the hcatalog part. The hive part
is straightforward, so I'll ignore that. The hcatalog part is more complicated,
because you have two goals :
* Make the hive hbase handler work from under hcatalog
* Make sure that the existing hbase hcat storage handler still works from
within hcat.
HCatalog now has two sections to it:
* org.apache.hive.hcatalog is the new package for all new work.
* org.apache.hcatalog , which is is now deprecated, and maintained only for
purposes of backward compatibility, and will be removed after about 2 more
releases. What's more, the code available here is the 0.11 released version of
code - i.e., for eg., HCatUtil might be different between the two versions
because any patches since 0.11 release are going only to the new codebase.
So, any changes you make that allow general hive storage handlers to work from
hcatalog must happen in the new packages.
However, the hbase hcat storage handler is part of the deprecated set, and is
retained as part of the old org.apache.hcatalog.* set, and there is only one
version of that. Any changes you make to that, nust be made in the old package.
If it would help, I'm willing to come over to your workplace on Monday and help
sort the changes out.
> Integrated StorageHandler for Hive and HCat using the HiveStorageHandler
> ------------------------------------------------------------------------
>
> Key: HIVE-4331
> URL: https://issues.apache.org/jira/browse/HIVE-4331
> Project: Hive
> Issue Type: Task
> Components: HBase Handler, HCatalog
> Affects Versions: 0.12.0
> Reporter: Ashutosh Chauhan
> Assignee: Viraj Bhat
> Fix For: 0.12.0
>
> Attachments: HIVE4331_07-17.patch, hive4331hcatrebase.patch,
> HIVE-4331.patch, StorageHandlerDesign_HIVE4331.pdf
>
>
> 1) Deprecate the HCatHBaseStorageHandler and "RevisionManager" from HCatalog.
> These will now continue to function but internally they will use the
> "DefaultStorageHandler" from Hive. They will be removed in future release of
> Hive.
> 2) Design a HivePassThroughFormat so that any new StorageHandler in Hive will
> bypass the HiveOutputFormat. We will use this class in Hive's
> "HBaseStorageHandler" instead of the "HiveHBaseTableOutputFormat".
> 3) Write new unit tests in the HCat's "storagehandler" so that systems such
> as Pig and Map Reduce can use the Hive's "HBaseStorageHandler" instead of the
> "HCatHBaseStorageHandler".
> 4) Make sure all the old and new unit tests pass without backward
> compatibility (except known issues as described in the Design Document).
> 5) Replace all instances of the HCat source code, which point to
> "HCatStorageHandler" to use the"HiveStorageHandler" including the
> "FosterStorageHandler".
> I have attached the design document for the same and will attach a patch to
> this Jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
