[ 
https://issues.apache.org/jira/browse/HIVE-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-5269:
------------------------------

    Attachment: HIVE-5269.D12873.1.patch

navis requested code review of "HIVE-5269 [jira] Use thrift binary type for 
conveying binary values in hiveserver2".

Reviewers: JIRA

HIVE-5269 Use thrift binary type for conveying binary values in hiveserver2

Currently, binary type is encoded to string in hiveserver2 and decoded in 
client. Just using binary type might make it simpler.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D12873

AFFECTED FILES
  jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java
  metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
  service/if/TCLIService.thrift
  service/src/gen/thrift/gen-cpp/TCLIService_types.cpp
  service/src/gen/thrift/gen-cpp/TCLIService_types.h
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TBinaryValue.java
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRow.java
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TColumn.java
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TColumnValue.java
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionReq.java
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRowSet.java
  
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStatus.java
  service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote
  service/src/gen/thrift/gen-py/TCLIService/ttypes.py
  service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote
  service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb
  service/src/java/org/apache/hive/service/cli/ColumnValue.java
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/30831/

To: JIRA, navis

                
> Use thrift binary type for conveying binary values in hiveserver2
> -----------------------------------------------------------------
>
>                 Key: HIVE-5269
>                 URL: https://issues.apache.org/jira/browse/HIVE-5269
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-5269.D12873.1.patch
>
>
> Currently, binary type is encoded to string in hiveserver2 and decoded in 
> client. Just using binary type might make it simpler.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to