[
https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766106#comment-13766106
]
Phabricator commented on HIVE-4844:
-----------------------------------
ashutoshc has commented on the revision "HIVE-4844 [jira] Add varchar data
type".
Mostly looks good. Some comments.
I don't see any changes in ColumnarSerde, LazyBinaryColumnarSede. If they
are not supported thats alright. But, if they are can you add tests for RCFile
data with these two serdes. Simlarily HBaseSerde and AvroSerde. If you intend
to support it will be good to add testcases for those, else support for them
can be added later as well.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:629 This
method belongs in TypeInfoUtils class.
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:160 Move
this method to TypeInfoUtils
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:169 This
to ParseUtils
ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:48 Shall we
also update this error message saying, first arg must be either string or
varchar ?
ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:56 Error
message
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:39-40
You need to mark all these fields as transient.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:36
You can add @Description annotation for this which will be useful for end users.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:401
This for CHAR right, for varchar we need not to do this.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:474
Can you check the standard here? We may get bitten by backward-compat issues
because of this latter.
REVISION DETAIL
https://reviews.facebook.net/D12699
To: JIRA, jdere
Cc: ashutoshc
> Add varchar data type
> ---------------------
>
> Key: HIVE-4844
> URL: https://issues.apache.org/jira/browse/HIVE-4844
> Project: Hive
> Issue Type: New Feature
> Components: Types
> Reporter: Jason Dere
> Assignee: Jason Dere
> Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch,
> HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch,
> HIVE-4844.15.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch,
> HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch,
> HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch,
> HIVE-4844.D12699.1.patch, screenshot.png
>
>
> Add new varchar data types which have support for more SQL-compliant
> behavior, such as SQL string comparison semantics, max length, etc.
> Char type will be added as another task.
> NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
