[
https://issues.apache.org/jira/browse/HIVE-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768001#comment-13768001
]
Phabricator commented on HIVE-5276:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-5276 [jira] Skip useless string
encoding stage for hiveserver2".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java:57 Let's get
rid of this comment and anything special we're doing for Hadoop 0.17. We
deprecated support for that version a long time ago.
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:98 I
admit that I haven't investigated this closely, but the fact that we're
overriding a user-configurable property with a hardcoded value seems like a red
flag. If this is genuinely necessary can you please add a comment explaining
the rationale? Thanks.
ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultFetchConverter.java:50 We
deprecated support for 0.17 and 0.18 a long time ago. Please remove.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:667 Please add this
to conf/hive-default.xml.template along with a template explaining what it
does. Also, is this something that we really want to expose to users at this
point in time?
REVISION DETAIL
https://reviews.facebook.net/D12879
To: JIRA, navis
Cc: cwsteinbach
> Skip useless string encoding stage for hiveserver2
> --------------------------------------------------
>
> Key: HIVE-5276
> URL: https://issues.apache.org/jira/browse/HIVE-5276
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-5276.D12879.1.patch
>
>
> Current hiveserver2 acquires rows in string format which is used for cli
> output. Then convert them into row again and convert to final format lastly.
> This is inefficient and memory consuming.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
