[
https://issues.apache.org/jira/browse/HIVE-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769742#comment-13769742
]
Eugene Koifman commented on HIVE-4531:
--------------------------------------
I realized I missed LogRetriever in the review:
1. It opens URLConnection in several places but doesn't close them.
2. Is this class meant to be used anywhere other than TempletonControllerJob?
If no, can it be moved to the same package and be made package private (To
reduce public API footprint)? Similarly, could all member variables/methods be
made as private as possible?
3. I think it would be really useful to add some higher level documentation
about the design. Why does this class exist? why does it parse JSPs, where
does it write the result, etc. I think 1 or 2 paragraphs would be sufficient.
> [WebHCat] Collecting task logs to hdfs
> --------------------------------------
>
> Key: HIVE-4531
> URL: https://issues.apache.org/jira/browse/HIVE-4531
> Project: Hive
> Issue Type: New Feature
> Components: HCatalog, WebHCat
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.12.0
>
> Attachments: HIVE-4531-1.patch, HIVE-4531-2.patch, HIVE-4531-3.patch,
> HIVE-4531-4.patch, HIVE-4531-5.patch, HIVE-4531-6.patch, HIVE-4531-7.patch,
> HIVE-4531-8.patch, samplestatusdirwithlist.tar.gz
>
>
> It would be nice we collect task logs after job finish. This is similar to
> what Amazon EMR does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
