----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/#review26181 -----------------------------------------------------------
beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java <https://reviews.apache.org/r/11334/#comment51141> This approach of setting the arguments going to be hard to read and maintain. Can you do something like this ? - replace the use of "private final String[] args" with a function "List<String> getBaseArgs(String jdbcUrl);" Then add ("-f", scriptFileName) to the list it returns ? Similarly add params to the list in testBeelineCommandLineHiveVariable ? Everything else looks good. - Thejas Nair On Sept. 10, 2013, 9:45 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11334/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2013, 9:45 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-4568 > https://issues.apache.org/jira/browse/HIVE-4568 > > > Repository: hive-git > > > Description > ------- > > 1. Added command variable substition > 2. Added test case > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 4c6eb9b > beeline/src/java/org/apache/hive/beeline/BeeLine.properties b6650cf > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 61bdeee > beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java c70003d > beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java > 4280449 > > Diff: https://reviews.apache.org/r/11334/diff/ > > > Testing > ------- > > > Thanks, > > Xuefu Zhang > >
