-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14155/
-----------------------------------------------------------
(Updated Sept. 17, 2013, 8:55 p.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Fixed a minor nit.
Bugs: HIVE-5297
https://issues.apache.org/jira/browse/HIVE-5297
Repository: hive-git
Description
-------
Hive does not consider the type of the partition column while writing
partitions. Consider for example the query:
create table tab1 (id1 int, id2 string) PARTITIONED BY(month string,day int)
row format delimited fields terminated by ',';
alter table tab1 add partition (month='June', day='second');
Hive accepts this query. However if you try to select from this table and
insert into another expecting schema match, it will insert nulls instead.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1af68a6
ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 393ef57
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 2ece97e
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java a704462
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java fb79823
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g ca667d4
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 767f545
ql/src/test/queries/clientnegative/illegal_partition_type.q PRE-CREATION
ql/src/test/queries/clientnegative/illegal_partition_type2.q PRE-CREATION
ql/src/test/queries/clientpositive/partition_type_check.q PRE-CREATION
ql/src/test/results/clientnegative/alter_table_add_partition.q.out bd9c148
ql/src/test/results/clientnegative/alter_view_failure5.q.out 4edb82c
ql/src/test/results/clientnegative/illegal_partition_type.q.out PRE-CREATION
ql/src/test/results/clientnegative/illegal_partition_type2.q.out PRE-CREATION
ql/src/test/results/clientpositive/parititon_type_check.q.out PRE-CREATION
ql/src/test/results/clientpositive/partition_type_check.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/14155/diff/
Testing
-------
Ran all tests.
Thanks,
Vikram Dixit Kumaraswamy
