[
https://issues.apache.org/jira/browse/HIVE-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771566#comment-13771566
]
Phabricator commented on HIVE-5209:
-----------------------------------
jdere has commented on the revision "HIVE-5209 [jira] JDBC support for varchar".
INLINE COMMENTS
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java:57 Yeah,
removed this from patch v4.
jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java:32 Sure, I can
remove this import as it appears that it is not being used here. However,
TableSchema calls ColumnDescriptor which calls TypeDescriptor, which also uses
quite a bit of serde classes (as well as TypeQualifiers). So there still might
be an issue here .. perhaps I can pull the serde-specific code out of
TypeDescriptor/TypeQualifiers, and move them to some utility class in the
service module.
It looks like I would have to move the following methods into a separate
utility class:
- TypeQualifiers.fromBaseTypeParams(BaseTypeParams)
- TypeDescriptor.TypeDescriptor(String
- ColumnDescriptor.ColumnDescriptor(FieldSchema, int)
- TableSchema.TableSchema(List<FieldSchema>)
- TableSchema(Schema)
jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java:157 Yes, will add
the column attributes here.
jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java:240 sure, will
change in next patch
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java:36 Ok, will have
ColumnAttributes as its own class.
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java:181 will change in next
patch
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java:187 will change in next
patch
service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java:53 ok,
will change in next patch
service/src/java/org/apache/hive/service/cli/TypeQualifiers.java:24 see
previous reply about usage of serde classes
service/src/java/org/apache/hive/service/cli/TypeQualifiers.java:29 will add
to next patch
service/if/TCLIService.thrift:44 added this change in patch v4
REVISION DETAIL
https://reviews.facebook.net/D12999
To: JIRA, jdere
Cc: cwsteinbach, thejas
> JDBC support for varchar
> ------------------------
>
> Key: HIVE-5209
> URL: https://issues.apache.org/jira/browse/HIVE-5209
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2, JDBC, Types
> Reporter: Jason Dere
> Assignee: Jason Dere
> Attachments: D12999.1.patch, HIVE-5209.1.patch, HIVE-5209.2.patch,
> HIVE-5209.4.patch, HIVE-5209.D12705.1.patch
>
>
> Support returning varchar length in result set metadata
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
