[
https://issues.apache.org/jira/browse/HIVE-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778955#comment-13778955
]
Hive QA commented on HIVE-5366:
-------------------------------
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12605169/HIVE-5366.patch
{color:green}SUCCESS:{color} +1 3162 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/914/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/914/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
> Refactor a few object inspector class to eliminate redundant information
> ------------------------------------------------------------------------
>
> Key: HIVE-5366
> URL: https://issues.apache.org/jira/browse/HIVE-5366
> Project: Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers, Types
> Affects Versions: 0.12.0
> Reporter: Xuefu Zhang
> Assignee: Xuefu Zhang
> Fix For: 0.13.0
>
> Attachments: HIVE-5366.patch
>
>
> AbstractPrimitiveObjectInspector class has two fields:
> {code}
> protected PrimitiveTypeEntry typeEntry;
> protected BaseTypeParams typeParams;
> {code}
> But PrimitiveTypeEntry already has member BaseTypeParams instance, which is
> identical to "typeParams" we see here. Thus, there is some redundant
> information stored at different places. Ideally, we should have a single
> point of truth.
> This refactoring is required by HIVE-3976 work. This is singled out to make
> the review easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
