[
https://issues.apache.org/jira/browse/HIVE-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780659#comment-13780659
]
Thejas M Nair commented on HIVE-5066:
-------------------------------------
Daniel, can also fix the checkstyle errors in this patch ?
{code}
[checkstyle] Running Checkstyle 5.5 on 616 files
[checkstyle] /home/hortonth/hive_apache/hcatalog/bin/templeton.cmd:1: Line does
not match expected header line of '\W*or more contributor license agreements.
See the NOTICE file$'.
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:46:
member def type at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:47:
member def type at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:48:
member def type at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:50:
ctor def at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:51:
ctor def lcurly at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:52:
ctor def child at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:53:
ctor def child at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:54:
ctor def child at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:55:
ctor def rcurly at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:57:
method def modifier at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:58:
method def modifier at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:59:
method def lcurly at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:60:
try at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:61:
try lcurly at indentation level 12 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:62:
try child at indentation level 16 not at correct indentation, 6
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:64:
try child at indentation level 16 not at correct indentation, 6
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:65:
while at indentation level 16 not at correct indentation, 6
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:66:
while child at indentation level 20 not at correct indentation, 8
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:67:
while rcurly at indentation level 16 not at correct indentation, 6
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:68:
try rcurly at indentation level 12 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:69:
catch lcurly at indentation level 12 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:70:
catch child at indentation level 16 not at correct indentation, 6
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:71:
catch rcurly at indentation level 12 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/ExecServiceImpl.java:72:
method def rcurly at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:56:
method def modifier at indentation level 4 not at correct indentation, 2
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:58:
if at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:59:
if child at indentation level 12 not at correct indentation, 6
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:60:
if rcurly at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:61:
method def child at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:62:
method def child at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:63:
for at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:64:
for child at indentation level 12 not at correct indentation, 6
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:65:
for rcurly at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:66:
method def child at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:67:
method def child at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:68:
for at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:69:
for child at indentation level 12 not at correct indentation, 6
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:70:
for rcurly at indentation level 8 not at correct indentation, 4
[checkstyle]
/home/hortonth/hive_apache/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java:71:
method def rcurly at indentation level 4 not at correct indentation, 2
{code}
> [WebHCat] Other code fixes for Windows
> --------------------------------------
>
> Key: HIVE-5066
> URL: https://issues.apache.org/jira/browse/HIVE-5066
> Project: Hive
> Issue Type: Sub-task
> Components: HCatalog
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.12.0
>
> Attachments: HIVE-5034-1.patch, HIVE-5066-2.patch, HIVE-5066-3.patch
>
>
> This is equivalent to HCATALOG-526, but updated to sync with latest trunk.
> NO PRECOMMIT TESTS
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
