[
https://issues.apache.org/jira/browse/HIVE-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781503#comment-13781503
]
Brock Noland commented on HIVE-5283:
------------------------------------
Great work guys!
Can you address these three issues in follow on jiras?
We should never be blindly converting throwable to an exception.
{noformat}
+ } catch (Throwable e) {
+ throw new HiveException(e);
+ }
{noformat}
This is non-standard:
{noformat}
+ transient private long value;
{noformat}
Unless we have a very good reason we shouldn't be exposing the members of
VectorizedRowBatch publicly.
> Merge vectorization branch to trunk
> -----------------------------------
>
> Key: HIVE-5283
> URL: https://issues.apache.org/jira/browse/HIVE-5283
> Project: Hive
> Issue Type: Bug
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: alltypesorc, HIVE-5283.1.patch, HIVE-5283.2.patch,
> HIVE-5283.3.patch, HIVE-5283.4.patch
>
>
> The purpose of this jira is to upload vectorization patch, run tests etc. The
> actual work will continue under HIVE-4160 umbrella jira.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
