[
https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782039#comment-13782039
]
Brock Noland commented on HIVE-5253:
------------------------------------
Hi,
Overall looks great!! Just a few items below:
* It looks like something is wrong with TestCompileProcessor in the patch? Look
how the class appears to be concatenated to itself?
* In parse, if the string does not contain and ending ` endPosition will be -1.
Should we check it's value after the for loop?
* In compile we aren't checking to see that the mkdir method returns true.
very-much nits:
Is this still true? It looks like you are handling escapes in the for loop?
{noformat}
+ //TODO Escape handling will be changed in follow on
{noformat}
Missing one space:
{noformat}
+ while (command.charAt(startPosition++) != '`' && startPosition<
command.length()){
{noformat}
Space is not same on both sides of lang:
{noformat}
+ throw new CompileProcessorException("Can not compile "+lang+ ". Hive can
only compile "+GROOVY);
{noformat}
> Create component to compile and jar dynamic code
> ------------------------------------------------
>
> Key: HIVE-5253
> URL: https://issues.apache.org/jira/browse/HIVE-5253
> Project: Hive
> Issue Type: Sub-task
> Reporter: Edward Capriolo
> Assignee: Edward Capriolo
> Attachments: HIVE-5253.10.patch.txt, HIVE-5253.1.patch.txt,
> HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt,
> HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
