[
https://issues.apache.org/jira/browse/HIVE-5407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-5407:
------------------------------
Attachment: D13191.1.patch
code6 requested code review of "HIVE-5407 [jira] show create table creating
unusable DDL when some reserved keywords exist".
Reviewers: JIRA
HIVE-5407
HIVE-701 already makes most reserved keywords available for
table/column/partition names and 'show create table' produces usable DDLs.
However I think it's better if we quote table/column/partition names for the
output of 'show create table', which is how mysql works and seems more robust.
For example, use select as column name will produce unusable DDL:
create table table_select(`select` string);
show create table table_select;
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D13191
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
ql/src/test/results/clientpositive/show_create_table_alter.q.out
ql/src/test/results/clientpositive/show_create_table_db_table.q.out
ql/src/test/results/clientpositive/show_create_table_delimited.q.out
ql/src/test/results/clientpositive/show_create_table_partitioned.q.out
ql/src/test/results/clientpositive/show_create_table_serde.q.out
ql/src/test/results/clientpositive/show_create_table_view.q.out
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/38757/
To: JIRA, code6
> show create table creating unusable DDL when some reserved keywords exist
> --------------------------------------------------------------------------
>
> Key: HIVE-5407
> URL: https://issues.apache.org/jira/browse/HIVE-5407
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Environment: hive 0.11
> Reporter: Zhichun Wu
> Priority: Minor
> Attachments: D13191.1.patch
>
>
> HIVE-701 already makes most reserved keywords available for
> table/column/partition names and 'show create table' produces usable DDLs.
> However I think it's better if we quote table/column/partition names for the
> output of 'show create table', which is how mysql works and seems more robust.
> For example, use select as column name will produce unusable DDL:
> {code}
> create table table_select(`select` string);
> show create table table_select;
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
