[
https://issues.apache.org/jira/browse/HIVE-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783365#comment-13783365
]
Edward Capriolo commented on HIVE-5400:
---------------------------------------
[~brocknoland]
Lets slow down a second. I think patching in this support for only hs2 is short
sided. I think we do want to bring this code all the way down to the CLI, even
if a local mode CLI can avoid this protection, I think completely skipping the
local mode code path is the wrong way. Also I do not like the hard codes here:
{code}
String[] commands = {"set", "dfs", "add", "delete"};
{code}
We have already abstractions like Processors and a class that acts as a
switchboard, I think they should have a way of describing what types of
commands they provide (enum possibly), and then letting the switch board make
the choice.
Lets come up with a clean design that makes sense in the long run and is
manageable not just something we hack in.
> Allow admins to disable compile and other commands
> --------------------------------------------------
>
> Key: HIVE-5400
> URL: https://issues.apache.org/jira/browse/HIVE-5400
> Project: Hive
> Issue Type: Sub-task
> Reporter: Brock Noland
> Assignee: Edward Capriolo
> Attachments: HIVE-5400.patch
>
>
> From here:
> https://issues.apache.org/jira/browse/HIVE-5253?focusedCommentId=13782220&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13782220
> I think we should afford admins who want to disable this functionality the
> ability to do so. Since such admins might want to disable other commands such
> as add or dfs, it wouldn't be much trouble to allow them to do this as well.
> For example we could have a configuration option "hive.available.commands"
> (or similar) which specified add,set,delete,reset, etc by default. Then check
> this value in CommandProcessorFactory. It would probably make sense to add
> this property to the restrict list.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
