[
https://issues.apache.org/jira/browse/HIVE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784335#comment-13784335
]
Brock Noland commented on HIVE-4669:
------------------------------------
I believe the test failure is unrelated. This is a trivial patch which doesn't
impact any users of Hive so I am fine with committing it. However, I did notice
that there is something funky with the patch. The first constructor which
doesn't take a username argument sets the instance variable userName to what I
presume is itself:
{noformat}
public Driver(HiveConf conf) {
this.conf = conf;
+ this.userName = userName;
+ }
{noformat}
Since we are fixing that, this constructor can be redirected through the first
constructor. I understand it's nit-picky since it's a good practice and we are
going to be modifying the patch again anyways, let's do that.
{noformat}
+ public Driver(HiveConf conf, String userName) {
+ this.conf = conf;
+ this.userName = userName;
}
{noformat}
> Make username available to semantic analyzer hooks
> --------------------------------------------------
>
> Key: HIVE-4669
> URL: https://issues.apache.org/jira/browse/HIVE-4669
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.10.0, 0.11.0
> Reporter: Shreepadma Venugopalan
> Assignee: Shreepadma Venugopalan
> Attachments: HIVE-4669.1.patch, HIVE-4669.2.patch
>
>
> Make username available to the semantic analyzer hooks.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
