[ 
https://issues.apache.org/jira/browse/HIVE-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786251#comment-13786251
 ] 

Hudson commented on HIVE-5395:
------------------------------

FAILURE: Integrated in Hive-trunk-hadoop1-ptest #190 (See 
[https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/190/])
HIVE-5395 - Various cleanup in ptf code (Edward Capriolo via Brock Noland) 
(brock: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1529174)
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/PTFInvocationSpec.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDesc.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDeserializer.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/BoundaryDef.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/CurrentRowDef.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/OrderDef.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/OrderExpressionDef.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PTFExpressionDef.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PTFInputDef.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PTFQueryInputDef.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PartitionDef.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PartitionedTableFunctionDef.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/RangeBoundaryDef.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/ShapeDetails.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/ValueBoundaryDef.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowExpressionDef.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowFrameDef.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowFunctionDef.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowTableFunctionDef.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/NPath.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/Noop.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/NoopWithMap.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionEvaluator.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionResolver.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java


> Various cleanup in ptf code
> ---------------------------
>
>                 Key: HIVE-5395
>                 URL: https://issues.apache.org/jira/browse/HIVE-5395
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>             Fix For: 0.13.0
>
>         Attachments: HIVE-5395.1.patch.txt, HIVE-5395.2.patch.txt, 
> HIVE-5395.3.patch.txt, HIVE-5395.4.patch.txt
>
>
> Some minor issues:
> Implementing classes on left side of equals
> Stack used instead of ArrayDeque
> Classes defined statically inside other files (when they do not need to be
> Checkstyle errors like indenting



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to