-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14590/
-----------------------------------------------------------
(Updated Oct. 11, 2013, 5:19 p.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Patch included more refactoring and test case fixes.
Bugs: HIVE-5520
https://issues.apache.org/jira/browse/HIVE-5520
Repository: hive-git
Description
-------
Refactoring the code to use static factory methods to replace existing
constructors.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java e5a35cd
ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java
42d897c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fe1845c
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java a61d10c
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0ed69e9
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 4a0393e
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java 1e9e1aa
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 614a5bc
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPower.java a462116
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRound.java 57e3f2d
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java
6caef3f
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java d44df6f
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java 1dfcb56
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSerDeStats.java bd9ea21
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFAbs.java 3b4a7ac
serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java add5bdf
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
5b18c8f
serde/src/java/org/apache/hadoop/hive/serde2/io/HiveDecimalWritable.java
81500a8
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveDecimal.java
08f251c
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveDecimalObjectInspector.java
92e47fa
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
5b3756f
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
9a93740
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveDecimalObjectInspector.java
d3fc6ea
serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java
82feeec
serde/src/test/org/apache/hadoop/hive/serde2/io/TestTimestampWritable.java
e54c105
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java
5e546c5
Diff: https://reviews.apache.org/r/14590/diff/
Testing
-------
No new tests necessary. Waiting for pre-commit test results.
Thanks,
Xuefu Zhang
