[
https://issues.apache.org/jira/browse/HIVE-5350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-5350:
------------------------------
Attachment: D13617.1.patch
navis requested code review of "HIVE-5350 [jira] Cleanup exception handling
around parallel orderby".
Reviewers: JIRA
HIVE-5350 Cleanup exception handling around parallel orderby
I think we should log the message to the console and the full exception to the
log:
ExecDriver:
try {
handleSampling(driverContext, mWork, job, conf);
job.setPartitionerClass(HiveTotalOrderPartitioner.class);
} catch (Exception e) {
console.printInfo("Not enough sampling data.. Rolling back to single
reducer task");
rWork.setNumReduceTasks(1);
job.setNumReduceTasks(1);
}
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D13617
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/PartitionKeySampler.java
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/41013/
To: JIRA, navis
> Cleanup exception handling around parallel orderby
> --------------------------------------------------
>
> Key: HIVE-5350
> URL: https://issues.apache.org/jira/browse/HIVE-5350
> Project: Hive
> Issue Type: Bug
> Reporter: Brock Noland
> Assignee: Navis
> Priority: Minor
> Attachments: D13617.1.patch
>
>
> I think we should log the message to the console and the full exception to
> the log:
> ExecDriver:
> {noformat}
> try {
> handleSampling(driverContext, mWork, job, conf);
> job.setPartitionerClass(HiveTotalOrderPartitioner.class);
> } catch (Exception e) {
> console.printInfo("Not enough sampling data.. Rolling back to
> single reducer task");
> rWork.setNumReduceTasks(1);
> job.setNumReduceTasks(1);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
