[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809287#comment-13809287
]
Eric Hanson commented on HIVE-5581:
-----------------------------------
Teddy,
Thanks for the patch. I think there is in error in the getDescriptor method
since you specify 2 arguments instead of 1. See my comments in the review board
entry.
You may need to create two separate VectorExpression classes, one for a long
input and one for a string input, so the vector expression descriptor pattern
matching works right to pick the right VectorExpression.
Do you think you could take this patch and update Vectorizer.java and
VectorizationContext.java (if needed) and do end-to-end tests to make sure the
function works from Hive SQL? Or did you already do end-to-end tests?
Eric
> Implement vectorized year/month/day... etc. for string arguments
> ----------------------------------------------------------------
>
> Key: HIVE-5581
> URL: https://issues.apache.org/jira/browse/HIVE-5581
> Project: Hive
> Issue Type: Sub-task
> Components: Query Processor
> Affects Versions: 0.13.0
> Reporter: Eric Hanson
> Assignee: Teddy Choi
> Attachments: HIVE-5581.1.patch.txt
>
>
> Functions year(), month(), day(), weekofyear(), hour(), minute(), second()
> need to be implemented for string arguments in vectorized mode.
> They already work for timestamp arguments.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
