[
https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810688#comment-13810688
]
Phabricator commented on HIVE-5657:
-----------------------------------
sershe has commented on the revision "HIVE-5657 [jira] TopN produces incorrect
results with count(distinct)".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java:387 this
changes the meaning to now refer to the field "this.value". Is it intended?
Previously it was not used. Perhaps the first "if" should be removed if not
used on purpose
REVISION DETAIL
https://reviews.facebook.net/D13797
To: JIRA, navis
Cc: sershe
> TopN produces incorrect results with count(distinct)
> ----------------------------------------------------
>
> Key: HIVE-5657
> URL: https://issues.apache.org/jira/browse/HIVE-5657
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Navis
> Priority: Critical
> Attachments: D13797.1.patch, D13797.2.patch, HIVE-5657.1.patch.txt,
> example.patch
>
>
> Attached patch illustrates the problem.
> limit_pushdown test has various other cases of aggregations and distincts,
> incl. count-distinct, that work correctly (that said, src dataset is bad for
> testing these things because every count, for example, produces one record
> only), so something must be special about this.
> I am not very familiar with distinct- code and these nuances; if someone
> knows a quick fix feel free to take this, otherwise I will probably start
> looking next week.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
