[
https://issues.apache.org/jira/browse/HIVE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810802#comment-13810802
]
Gunther Hagleitner commented on HIVE-5688:
------------------------------------------
Few comments:
- non should be named none
- The enums should be mr, tez and none (that way you don't have a naming
conflict between the boolean flag and the enum value)
- You can handle any conversion string <-> enum in the valueOf method itself.
If you really don't recognize the input an error is probably appropriate.
> TestCliDriver compilation fails on tez branch.
> ----------------------------------------------
>
> Key: HIVE-5688
> URL: https://issues.apache.org/jira/browse/HIVE-5688
> Project: Hive
> Issue Type: Bug
> Components: Tez
> Affects Versions: tez-branch
> Reporter: Vikram Dixit K
> Assignee: Vikram Dixit K
> Attachments: HIVE-5688.1.patch
>
>
> On the tez branch, the test cli driver tests fail to compile after HIVE-5543.
--
This message was sent by Atlassian JIRA
(v6.1#6144)