> On Nov. 7, 2013, 4:31 p.m., Brock Noland wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979
> > <https://reviews.apache.org/r/14486/diff/4/?file=380248#file380248line979>
> >
> > Question: what happens if compile throws an exception, like NPE or
> > something. Does that mean the locks do not get released?
> >
> > If that is true then I think we should follow a follow-on jira, as it's
> > not introduced here, to ensure the locks are released.
>
> Thejas Nair wrote:
> The lock will be freed if an exception is thrown. That is not a problem.
>
>
> Brock Noland wrote:
> Great to hear! For my own learning purposes, could you share how exactly
> that will occur? I just don't see it.
Using
sychronized(obj){
//sync code
}
is equivalent to -
obj.intrinsicLock.lock();
try{
//sync code
}
finally{
//gets called even on exception
obj.intrinsicLock.unlock();
}
- Thejas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28376
-----------------------------------------------------------
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
> 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
