----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15993/ -----------------------------------------------------------
(Updated Dec. 5, 2013, 3:37 a.m.) Review request for hive and Ashutosh Chauhan. Changes ------- 1. Changed not to reset stats when "compute statistics noscan" is used 2. Removed assert in Utilities.getHashedStatsPrefix() which is added in previous diff. That makes some tests fail (stats19.q, etc.) Bugs: HIVE-5936 https://issues.apache.org/jira/browse/HIVE-5936 Repository: hive-git Description ------- With counter mechanism, MR job is successful, but StatsTask on client fails with NPE Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java cbc3cd2 ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java e7453c7 ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 142af10 ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 8d895f4 ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 91a9e6c ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanMapper.java 7e701f4 ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java cca8481 ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java 0268f98 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e9d9ee7 ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java 2cc2519 ql/src/java/org/apache/hadoop/hive/ql/stats/StatsFactory.java 8ae32f0 ql/src/test/queries/clientpositive/stats_counter.q 20769e4 ql/src/test/queries/clientpositive/stats_noscan_2.q a19d01b ql/src/test/results/clientpositive/stats_counter.q.out f15d8c5 ql/src/test/results/clientpositive/stats_noscan_1.q.out 054ca38 ql/src/test/results/clientpositive/stats_noscan_2.q.out e55fa94 Diff: https://reviews.apache.org/r/15993/diff/ Testing ------- Thanks, Navis Ryu