----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15495/#review30148 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringColumnStringColumn.java <https://reviews.apache.org/r/15495/#comment57720> It is possible that arg2ColVector and arg3ColVector have nulls, even though argColVector has no-nulls. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringColumnStringColumn.java <https://reviews.apache.org/r/15495/#comment57722> Null check needed for arg2ColVector and arg3ColVector. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringColumnStringScalar.java <https://reviews.apache.org/r/15495/#comment57723> Null check for arg3ColVector. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringColumnStringScalar.java <https://reviews.apache.org/r/15495/#comment57724> Null check. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringScalarStringColumn.java <https://reviews.apache.org/r/15495/#comment57725> Null check for arg3ColVector. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringScalarStringColumn.java <https://reviews.apache.org/r/15495/#comment57726> Null check. - Jitendra Pandey On Dec. 9, 2013, 11:50 p.m., Eric Hanson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15495/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2013, 11:50 p.m.) > > > Review request for hive, Ashutosh Chauhan, Jitendra Pandey, and Teddy Choi. > > > Bugs: HIVE-5756 > https://issues.apache.org/jira/browse/HIVE-5756 > > > Repository: hive-git > > > Description > ------- > > Implement vectorization support for IF conditional expression for long and > double inputs > > > Diffs > ----- > > ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 1d3c5c4 > ql/src/gen/vectorization/ExpressionTemplates/IfExprColumnColumn.txt > PRE-CREATION > ql/src/gen/vectorization/ExpressionTemplates/IfExprColumnScalar.txt > PRE-CREATION > ql/src/gen/vectorization/ExpressionTemplates/IfExprScalarColumn.txt > PRE-CREATION > ql/src/gen/vectorization/ExpressionTemplates/IfExprScalarScalar.txt > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java > e1d4543 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java 48b87ea > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/DoubleColumnVector.java > d3bb28e > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/LongColumnVector.java > f65e8fa > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringColumnStringColumn.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringColumnStringScalar.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringScalarStringColumn.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringScalarStringScalar.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 7859e56 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIf.java 0c7e61c > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java > 720ca54 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.java > a250c9d > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorConditionalExpressions.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15495/diff/ > > > Testing > ------- > > > Thanks, > > Eric Hanson > >