> On Dec. 18, 2013, 5:37 a.m., Xuefu Zhang wrote: > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java, > > line 774 > > <https://reviews.apache.org/r/15654/diff/4/?file=399245#file399245line774> > > > > I don't think we need the bridge udf for generic UDFs.
This change is only to replace UDFLTrim with new GenericUDFLTrim used in this test case. Generic bridge UDF is already there. > On Dec. 18, 2013, 5:37 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java, > > line 109 > > <https://reviews.apache.org/r/15654/diff/4/?file=399238#file399238line109> > > > > I'm not sure if this is intentional, but the logic here means that any > > of the three input can have a type of INT. If INT is okay, then why not > > BYTE, SHORT, or LONG? It's probably better to check each argument's type > > separately. will do. > On Dec. 18, 2013, 5:37 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java, > > line 48 > > <https://reviews.apache.org/r/15654/diff/4/?file=399238#file399238line48> > > > > Msg doesn't match the if condition. will correct. - Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15654/#review30604 ----------------------------------------------------------- On Dec. 18, 2013, 3:16 a.m., Mohammad Islam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15654/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2013, 3:16 a.m.) > > > Review request for hive, Ashutosh Chauhan, Carl Steinbach, and Jitendra > Pandey. > > > Bugs: HIVE-5829 > https://issues.apache.org/jira/browse/HIVE-5829 > > > Repository: hive-git > > > Description > ------- > > Rewrite the UDFS *pads and *trim using GenericUDF. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java a895d65 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > bca1f26 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLTrim.java dc00cf9 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLpad.java d1da19a > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRTrim.java 2bcc5fa > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRpad.java 9652ce2 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTrim.java 490886d > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLTrim.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLpad.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRTrim.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRpad.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrim.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java > eff251f > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLTrim.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLpad.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRTrim.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRpad.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFTrim.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15654/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Islam > >
