----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16299/ -----------------------------------------------------------
(Updated Dec. 19, 2013, 4:37 p.m.) Review request for hive, Ashutosh Chauhan and Alan Gates. Changes ------- fix test diffs introduced because of turning on this feature. Bugs: HIVE-6013 https://issues.apache.org/jira/browse/HIVE-6013 Repository: hive-git Description ------- Hive's current behavior on Quoted Identifiers is different from the normal interpretation. Quoted Identifier (using backticks) has a special interpretation for Select expressions(as Regular Expressions). Have documented current behavior and proposed a solution in attached doc. Summary of solution is: Introduce 'standard' quoted identifiers for columns only. At the langauage level this is turned on by a flag. At the metadata level we relax the constraint on column names. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fa3e048 itests/qtest/pom.xml 971c5d3 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 5b75ef3 ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java eb26e7f ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 321759b ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java dbf3f91 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g ed9917d ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 1e6826f ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b9cd65c ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 8fe2262 ql/src/test/queries/clientnegative/ambiguous_col1.q fdf20f8 ql/src/test/queries/clientnegative/ambiguous_col2.q de59bc5 ql/src/test/queries/clientnegative/invalid_columns.q f8be8c8 ql/src/test/queries/clientnegative/regex_col_1.q 8333ddc ql/src/test/queries/clientnegative/regex_col_2.q d1aa1f1 ql/src/test/queries/clientnegative/regex_col_groupby.q 5397191 ql/src/test/queries/clientpositive/ambiguous_col.q e7053c1 ql/src/test/queries/clientpositive/quotedid_alter.q PRE-CREATION ql/src/test/queries/clientpositive/quotedid_basic.q PRE-CREATION ql/src/test/queries/clientpositive/quotedid_partition.q PRE-CREATION ql/src/test/queries/clientpositive/quotedid_skew.q PRE-CREATION ql/src/test/queries/clientpositive/quotedid_smb.q PRE-CREATION ql/src/test/queries/clientpositive/quotedid_tblproperty.q PRE-CREATION ql/src/test/queries/clientpositive/regex_col.q 9cfcee5 ql/src/test/queries/clientpositive/show_tablestatus.q 9184d6d ql/src/test/queries/clientpositive/udf_index.q 9079d0e ql/src/test/results/clientnegative/invalid_columns.q.out 3311b0a ql/src/test/results/clientnegative/invalidate_view1.q.out 9f3870e ql/src/test/results/clientnegative/regex_col_1.q.out 2025aee ql/src/test/results/clientnegative/regex_col_2.q.out 171a66f ql/src/test/results/clientnegative/regex_col_groupby.q.out 0730f14 ql/src/test/results/clientpositive/auto_join_reordering_values.q.out d61f5d2 ql/src/test/results/clientpositive/escape_clusterby1.q.out f1878dc ql/src/test/results/clientpositive/escape_distributeby1.q.out c71a0d8 ql/src/test/results/clientpositive/escape_orderby1.q.out 70a0bf8 ql/src/test/results/clientpositive/escape_sortby1.q.out 3530622 ql/src/test/results/clientpositive/index_bitmap3.q.out 3bda9bd ql/src/test/results/clientpositive/index_bitmap_auto.q.out 2cbbf00 ql/src/test/results/clientpositive/quote1.q.out 9ac271d ql/src/test/results/clientpositive/quotedid_alter.q.out PRE-CREATION ql/src/test/results/clientpositive/quotedid_basic.q.out PRE-CREATION ql/src/test/results/clientpositive/quotedid_partition.q.out PRE-CREATION ql/src/test/results/clientpositive/quotedid_skew.q.out PRE-CREATION ql/src/test/results/clientpositive/quotedid_smb.q.out PRE-CREATION ql/src/test/results/clientpositive/quotedid_tblproperty.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16299/diff/ Testing ------- added new tests for create, alter, delete, query with columns containing special characters. Tests start with quotedid Thanks, Harish Butani