> On Dec. 19, 2013, 11:43 a.m., Ashutosh Chauhan wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 345 > > <https://reviews.apache.org/r/16339/diff/2/?file=399690#file399690line345> > > > > This should be on by default. After HIVE-5297 storing column values in > > non-canonical forms should not happen. > > Sergey Shelukhin wrote: > As far as I see, the jira doesn't do normalization, just verification. On > trunk the issue still happens
So will it result in incorrect result or exception? If this is exception, I will suggest to have config on by default. If it silently results in incorrect results, than off by default is better. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16339/#review30694 ----------------------------------------------------------- On Dec. 19, 2013, 2:17 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16339/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2013, 2:17 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fa3e048 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > a98d9d1 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 04d399f > > metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java > 93e9942 > ql/src/test/queries/clientpositive/alter_partition_coltype.q 5479afb > ql/src/test/queries/clientpositive/annotate_stats_part.q 83510e3 > ql/src/test/queries/clientpositive/dynamic_partition_skip_default.q 397a220 > ql/src/test/results/clientpositive/alter_partition_coltype.q.out 27b1fbc > ql/src/test/results/clientpositive/annotate_stats_part.q.out 87fb980 > ql/src/test/results/clientpositive/dynamic_partition_skip_default.q.out > baee525 > > Diff: https://reviews.apache.org/r/16339/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
