----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16412/ -----------------------------------------------------------
Review request for hive and Ashutosh Chauhan. Bugs: HIVE-6048 https://issues.apache.org/jira/browse/HIVE-6048 Repository: hive-git Description ------- The issue, including its old cousin, is caused by encoding/decoding of URI.toString, Path.toString(), file path etc. It's found that the best approach is to use URI to represent a file and URI.getPath() gives the correct decoded file path. The fix in this patch is mostly about passing URI around so that acurate file info isn't lost during passing. Diffs ----- data/files/person c902284 data/files/person+age.txt PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java 38d97e3 ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 5cb492f ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java fd811f3 ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java dbf3f91 ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java 33111e5 ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java e97d948 ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java c2981e8 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b9cd65c ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java de31b21 ql/src/java/org/apache/hadoop/hive/ql/plan/LoadDesc.java bada915 ql/src/java/org/apache/hadoop/hive/ql/plan/LoadFileDesc.java 40adca7 ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java 7d555e4 ql/src/test/queries/clientpositive/load_file_with_space_in_the_name.q 672d5d2 ql/src/test/queries/clientpositive/load_hdfs_file_with_space_in_the_name.q d4520e2 ql/src/test/results/clientpositive/load_file_with_space_in_the_name.q.out af6fd10 ql/src/test/results/clientpositive/load_hdfs_file_with_space_in_the_name.q.out 1e7fa33 ql/src/test/results/compiler/plan/case_sensitivity.q.xml 27d064f ql/src/test/results/compiler/plan/groupby1.q.xml 00500bb ql/src/test/results/compiler/plan/input1.q.xml 28a2237 ql/src/test/results/compiler/plan/input2.q.xml d96bfab ql/src/test/results/compiler/plan/input3.q.xml 46fe7f9 ql/src/test/results/compiler/plan/input4.q.xml 98e28d4 ql/src/test/results/compiler/plan/input5.q.xml 806c3bf ql/src/test/results/compiler/plan/input6.q.xml 8b2e348 ql/src/test/results/compiler/plan/input7.q.xml 8ae403b ql/src/test/results/compiler/plan/input9.q.xml f8a2f76 ql/src/test/results/compiler/plan/input_testsequencefile.q.xml d8697ff ql/src/test/results/compiler/plan/join1.q.xml 9e4b609 ql/src/test/results/compiler/plan/join2.q.xml efcb865 ql/src/test/results/compiler/plan/join3.q.xml 9bbe64f ql/src/test/results/compiler/plan/sample2.q.xml 568cea8 ql/src/test/results/compiler/plan/sample3.q.xml c23313b ql/src/test/results/compiler/plan/sample4.q.xml 568cea8 ql/src/test/results/compiler/plan/sample5.q.xml f60cb96 ql/src/test/results/compiler/plan/sample6.q.xml 5bb3dbc ql/src/test/results/compiler/plan/sample7.q.xml 152cc08 ql/src/test/results/compiler/plan/subq.q.xml 8990b76 ql/src/test/results/compiler/plan/union.q.xml 6cab061 Diff: https://reviews.apache.org/r/16412/diff/ Testing ------- New unit tests are added. Some old tests have newly generated output. Thanks, Xuefu Zhang