-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16184/
-----------------------------------------------------------
(Updated Dec. 30, 2013, 10:41 p.m.)
Review request for hive, Eric Hanson and Thejas Nair.
Changes
-------
Fixed the patch based on Thejas's comment
Bugs: hive-5795
https://issues.apache.org/jira/browse/hive-5795
Repository: hive-git
Description
-------
Hive should be able to skip header and footer rows when reading data file for a
table
(follow up with review https://reviews.apache.org/r/15663/diff/#index_header)
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2ddb08f
conf/hive-default.xml.template b94013a
data/files/header_footer_table_1/0001.txt PRE-CREATION
data/files/header_footer_table_1/0002.txt PRE-CREATION
data/files/header_footer_table_1/0003.txt PRE-CREATION
data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION
data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION
data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION
itests/qtest/pom.xml 88e0890
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 03fd30a
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java fc9b7e4
ql/src/java/org/apache/hadoop/hive/ql/exec/FooterBuffer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java daf4e4a
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
dd5cb6b
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 974a5d6
ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java
85dd975
ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java
0686d9b
ql/src/test/queries/clientnegative/file_with_header_footer_negative.q
PRE-CREATION
ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION
ql/src/test/results/clientnegative/file_with_header_footer_negative.q.out
PRE-CREATION
ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION
serde/if/serde.thrift 2ceb572
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
22a6168
Diff: https://reviews.apache.org/r/16184/diff/
Testing
-------
Thanks,
Shuaishuai Nie
