[
https://issues.apache.org/jira/browse/HIVE-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859172#comment-13859172
]
Jitendra Nath Pandey commented on HIVE-6017:
--------------------------------------------
The code looks good to me. +1
It seems the copywrite needs to be mentioned in the NOTICE file as well,
although I am not an expert on these rules. Please also refer to
http://www.apache.org/licenses/ to comply with the guidelines when submitting
code with employer copywrite or third-party code. Does it require a Software
Grant Agreement (SGA) with PMC?
> Contribute Decimal128 high-performance decimal(p, s) package from Microsoft
> to Hive
> -----------------------------------------------------------------------------------
>
> Key: HIVE-6017
> URL: https://issues.apache.org/jira/browse/HIVE-6017
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 0.13.0
> Reporter: Eric Hanson
> Assignee: Eric Hanson
> Attachments: HIVE-6017.01.patch, HIVE-6017.02.patch,
> HIVE-6017.03.patch, HIVE-6017.04.patch
>
>
> Contribute the Decimal128 high-performance decimal package developed by
> Microsoft to Hive. This was originally written for Microsoft PolyBase by
> Hideaki Kimura.
> This code is about 8X more efficient than Java BigDecimal for typical
> operations. It uses a finite (128 bit) precision and can handle up to
> decimal(38, X). It is also "mutable" so you can change the contents of an
> existing object. This helps reduce the cost of new() and garbage collection.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
