Wow, immediate gratification. Thanks very much, Brock, and Happy New Year everybody!
-- Lefty On Mon, Dec 30, 2013 at 7:27 AM, Brock Noland <br...@cloudera.com> wrote: > On Mon, Nov 18, 2013 at 2:21 PM, Lefty Leverenz <leftylever...@gmail.com > >wrote: > > > Thanks for the typo alert Remus, I've changed -Dcase=TestCliDriver to > > -Dtest=TestCliDriver. > > > > Thank you for this!! > > > > > > But HowToContribute< > > > https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute > > >still > > has several instances of "ant" that should be changed to "mvn" -- > > some are simple replacements but others might need additional changes: > > > > - Check for new Checkstyle <http://checkstyle.sourceforge.net/> > > violations > > by running ant checkstyle, ... [mvn checkstyle?] > > > > We have not implemented checkstyle on maven yet. I created > https://issues.apache.org/jira/browse/HIVE-6123 > > > > - Define methods within your class whose names begin with test, and > call > > JUnit's many assert methods to verify conditions; these methods will > be > > executed when you run ant test. [simple replacement] > > - (2 ants) We can run "ant test -Dtestcase=TestAbc" where TestAbc is > the > > name of the new class. This will test only the new testcase, which > will > > be > > faster than "ant test" which tests all testcases. [change ant to mvn > > twice; also change -Dtestcase to -Dtest?] > > - Folks should run ant clean package test before selecting *Submit > > Patch*. > > [mvn clean package?] > > > > I have updated the above. > > > > > > The rest of the "ant" instances are okay because the MVN section > afterwards > > gives the alternative, but should we keep ant or make the replacements? > > > > - 9. Now you can run the ant 'thriftif' target ... > > - 11. ant thriftif -Dthrift.home=... > > - 15. ant thriftif > > - 18. ant clean package > > - The maven equivalent of ant thriftif is: > > > > mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local > > > > > > > I have not generated the thrift stuff recently. It would be great if Alan > or someone else who has would update this section. > > Thank you!! >
