-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16558/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-6105
https://issues.apache.org/jira/browse/HIVE-6105
Repository: hive-git
Description
-------
Compiled hive against hadoop-2. Running tests on hadoop 1 gives:
Caused by: java.lang.NoSuchMethodError:
org.apache.hadoop.io.LongWritable.compareTo(Lorg/apache/hadoop/io/LongWritable;)I
at
org.apache.hadoop.hive.ql.udf.UDAFPercentile$MyComparator.compare(UDAFPercentile.java:62)
at
org.apache.hadoop.hive.ql.udf.UDAFPercentile$MyComparator.compare(UDAFPercentile.java:58)
at java.util.Arrays.mergeSort(Arrays.java:1270)
at java.util.Arrays.sort(Arrays.java:1210)
at java.util.Collections.sort(Collections.java:157)
at
org.apache.hadoop.hive.ql.udf.UDAFPercentile$PercentileLongEvaluator.terminate(UDAFPercentile.java:194)
... 20 more
I think the problem is that the compareTo function has changed from using
Object to using LongWritable as an argument. Seems this needs a shim. However,
we should also make sure that this shim doesn't hit performance too hard.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/UDAFPercentile.java 4186a9d
ql/src/test/queries/clientpositive/udaf_percentile.q PRE-CREATION
ql/src/test/results/clientpositive/udaf_percentile.q.out PRE-CREATION
shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
6ff1a84
shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
62f7984
shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
cac1594
shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java
0d5615c
Diff: https://reviews.apache.org/r/16558/diff/
Testing
-------
Thanks,
Navis Ryu
