> On Jan. 2, 2014, 5:37 p.m., Sergey Shelukhin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 1347 > > <https://reviews.apache.org/r/15873/diff/2/?file=404158#file404158line1347> > > > > wouldn't this be true in case of many error paths above? > > Where driverCxt.shutdown(); is called
The executor thread throws exception very after calling Driver.shutdown(). This code should be walked only when shutdown is called by other thread. - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/#review31039 ----------------------------------------------------------- On Dec. 30, 2013, 6:57 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15873/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2013, 6:57 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5901 > https://issues.apache.org/jira/browse/HIVE-5901 > > > Repository: hive-git > > > Description > ------- > > Currently, query canceling does not stop running MR job immediately. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 62fc150 > ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1c84523 > ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java ead7b59 > > Diff: https://reviews.apache.org/r/15873/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
