[jira] [Comment Edited] (HIVE-6115) Remove redundant code in HiveHBaseStorageHandler

[Brock Noland (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863466#comment-13863466
 ] 

Brock Noland edited comment on HIVE-6115 at 1/6/14 9:47 PM:
------------------------------------------------------------

Hi,

Thanks for this. The issue is that this code right here:

{noformat}
     if (this.configureInputJobProps) {
       try {
        HBaseConfiguration.addHbaseResources(jobConf);
{noformat}

Adds hbase-default.xml as a resource to the jobConf and it does so after hbase 
configuration may already be added to the jobconf and thereby overrides any 
local configuration. Since HiveHBaseStorageHandler. addHBaseResources the 
relevant hbase configuration should already be present, my contention is that 
line should be removed.


was (Author: brocknoland):
Hi,

Thanks for this. The issue is that this code right here:

{noformat}
     if (this.configureInputJobProps) {
       try {
        HBaseConfiguration.addHbaseResources(jobConf);
{noformat}

Adds hbase-default.xml as a resource to the jobConf and thereby overrides any 
local configuration. Since HiveHBaseStorageHandler. addHBaseResources the 
relevant hbase configuration should already be present, my contention is that 
line should be removed.

> Remove redundant code in HiveHBaseStorageHandler
> ------------------------------------------------
>
>                 Key: HIVE-6115
>                 URL: https://issues.apache.org/jira/browse/HIVE-6115
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.12.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: HIVE-6115.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)