[ 
https://issues.apache.org/jira/browse/HIVE-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864546#comment-13864546
 ] 

Eugene Koifman commented on HIVE-4773:
--------------------------------------

[~shuainie] if you look at the code currently in trunk, it already has 
"needCloseOutput" variable and a block
if(out != System.err && out != System.out) {
          //depending on FileSystem implementation flush() may or may not do 
anything 
          writer.close();
        }

both attempt to solve this very problem (though needCloseOutput) is sufficient.

If you'd like to clean this up using NonClosableStream it's fine, but then the 
old code needs to be removed.

> webhcat intermittently fail to commit output to file system
> -----------------------------------------------------------
>
>                 Key: HIVE-4773
>                 URL: https://issues.apache.org/jira/browse/HIVE-4773
>             Project: Hive
>          Issue Type: Bug
>          Components: WebHCat
>            Reporter: Shuaishuai Nie
>            Assignee: Shuaishuai Nie
>         Attachments: HIVE-4773.1.patch, HIVE-4773.2.patch, HIVE-4773.3.patch, 
> HIVE-4773.4.patch
>
>
> With ASV as a default FS, we saw instances where output is not fully flushed 
> to storage before the Templeton controller process exits. This results in 
> stdout and stderr being empty even though the job completed successfully.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to