[ 
https://issues.apache.org/jira/browse/HIVE-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868763#comment-13868763
 ] 

Hive QA commented on HIVE-6186:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12622482/HIVE-6186.01.patch

{color:green}SUCCESS:{color} +1 4917 tests passed

Test results: 
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/861/testReport
Console output: 
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/861/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12622482

> error in vectorized Column-Column comparison filter for repeating case
> ----------------------------------------------------------------------
>
>                 Key: HIVE-6186
>                 URL: https://issues.apache.org/jira/browse/HIVE-6186
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Query Processor
>    Affects Versions: 0.13.0
>            Reporter: Eric Hanson
>            Assignee: Eric Hanson
>         Attachments: HIVE-6186.01.patch
>
>
> FilterColumnCompareColumn.txt  contains this code:
>     } else if (inputColVector1.isRepeating && inputColVector2.isRepeating) {
>       if (nullPos1[0] || nullPos2[0]) {
>         batch.size = 0; 
>       } 
> This code examines nullPos1[0] and nullPos2[0] without checking that 
> noNulls==false for the appropriate vector. This could lead to incorrect 
> results.
> We should review the case analysis for this template more generally to make 
> sure that all combinations are covered:
> left.noNulls        right.noNulls
> T                         T
> F                         T
> T                         F
> F                         F                 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to