----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16938/#review32325 -----------------------------------------------------------
Looks fine to me. As you mentioned on the ticket, the filesystem equality check fails in most conditions and we don't hit this problem. It would be helpful to add a test case to verify the behavior. - Prasad Mujumdar On Jan. 16, 2014, 1:45 a.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16938/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 1:45 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6209 > https://issues.apache.org/jira/browse/HIVE-6209 > > > Repository: hive-git > > > Description > ------- > > There was a wrong condition introduced in HIVE-3756, that prevented load data > overwrite from working properly. In these situations, destf == oldPath == > /user/warehouse/hive/<tableName>, so -rmr was skipped on old data. > > Note that if file name was same, ie load data inpath '<path>' with same path > repeatedly, it would work as the rename would overwrite the old data file. > But in this case, the filename is different. > > Other minor changes are trying to improve logging in this area to better > diagnose the issues (for example file permission, etc). > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2fe86e1 > > Diff: https://reviews.apache.org/r/16938/diff/ > > > Testing > ------- > > The primary concern was whether removing the directory in these scenarios > would make the rename fail. It should not due to fs.mkdirs call before, but > I still verified the following scenarios: > > load/insert overwrite into table with partitions > load/insert overwrite into table with buckets > > > Thanks, > > Szehon Ho > >
